[
https://issues.apache.org/jira/browse/GEODE-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295753#comment-16295753
]
ASF GitHub Bot commented on GEODE-4080:
---------------------------------------
WireBaron commented on a change in pull request #1171: GEODE-4080: Protobuf
JSON objects are in a proto string
URL: https://github.com/apache/geode/pull/1171#discussion_r157615529
##########
File path:
geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/v1/utilities/ProtobufEncodingTypes.java
##########
@@ -28,22 +35,25 @@
BOOLEAN(Boolean.class),
DOUBLE(Double.class),
FLOAT(Float.class),
- BINARY(byte[].class);
+ BINARY(byte[].class),
+
+ // This will probably have to change once the protocol supports multiple
object encodings.
+ PDX_OBJECT(PdxInstance.class);
Review comment:
I kind of liked having this enum as a way to identify which types were
en/de-codable directly by the protobuf code as opposed to those needing a
custom encoder/decoder provided by the server (and also by the client).
Without that distinction, does it make sense to move this enum into the
ProtobufSerializationService class?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve JSON encoding for new protocol
> --------------------------------------
>
> Key: GEODE-4080
> URL: https://issues.apache.org/jira/browse/GEODE-4080
> Project: Geode
> Issue Type: Improvement
> Components: client/server
> Reporter: Galen O'Sullivan
>
> One of the encoding types in the new protobuf protocol is called
> {{CustomEncodedValue}}. However, users aren't really free to encode their own
> types. Also, packing JSON into a byte array is going to be harder for users
> than just sending ti as a string. Let's make the JSON type a string and put
> the custom value type in later when we actually have support for custom
> encoding.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
