[
https://issues.apache.org/jira/browse/GEODE-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300215#comment-16300215
]
ASF GitHub Bot commented on GEODE-4030:
---------------------------------------
metatype commented on a change in pull request #1199: GEODE-4030, GEODE-3495:
Bump dependencies to new versions
URL: https://github.com/apache/geode/pull/1199#discussion_r158311283
##########
File path:
extensions/geode-modules-session/src/test/java/org/apache/geode/modules/session/internal/filter/SessionReplicationIntegrationJUnitTest.java
##########
@@ -451,102 +391,16 @@ private Cookie findUserCookie(Cookie[] cookies) {
return userCookie;
}
- // Don't see how to do this currently as the SessionListener needs a full
- // web context to work in.
-
- // /**
- // * Test that sessions expire correctly
- // */
- // public void testSessionExpiration() throws Exception {
- // Callback c_1 = new Callback() {
- // @Override
- // public void call(HttpServletRequest request, HttpServletResponse response)
- // throws IOException, ServletException {
- // HttpSession s = request.getSession();
- // s.setAttribute("foo", "bar");
- // s.setMaxInactiveInterval(1);
- //
- // PrintWriter out = response.getWriter();
- // out.write(s.getId());
- // }
- // };
- //
- // // This is the callback used to check if the session is still there
- // Callback c_2 = new Callback() {
- // @Override
- // public void call(HttpServletRequest request, HttpServletResponse response)
- // throws IOException, ServletException {
- // HttpSession s = request.getSession(false);
- // String output;
- // if (s == null) {
- // output = "null";
- // } else {
- // output = s.getId();
- // }
- //
- // PrintWriter out = response.getWriter();
- // out.write(output);
- // }
- // };
- //
- // tester.addEventListener(new SessionListener());
- // tester.setAttribute("callback_1", c_1);
- // tester.setAttribute("callback_2", c_2);
- //
- // servletHolder.setInitParameter("test.callback", "callback_1");
- //
- // ServletHolder sh2 = tester.addServlet(BasicServlet.class, "/request2");
- // sh2.setInitParameter("test.callback", "callback_2");
- //
- // tester.start();
- // ContextManager.getInstance().putContext(
- // servletHolder.getServlet().getServletConfig().getServletContext());
- //
- // request.setMethod("GET");
- // request.setURI("/test/hello");
- // request.setHeader("Host", "tester");
- // request.setVersion("HTTP/1.0");
- // response.parse(tester.getResponses(request.generate()));
- //
- // String id = response.getContent();
- //
- // // Wait for the session to expire
- // Thread.sleep(2000);
- //
- // request.setHeader("Cookie", "JSESSIONID=" + id);
- // request.setURI("/test/request2");
- // response.parse(tester.getResponses(request.generate()));
- //
- // assertIndexDetailsEquals("null", response.getContent());
- //
- // Region r = getRegion();
- // assertNull("Region should not contain session", r.get(id));
- // }
-
/**
* Test that invalidating a session destroys it as well as the backend
object.
*/
- @Category(FlakyTest.class) // GEODE-1015: uses Jetty HttpTester, uses static
vars with class
- // loader isolation, TODO: rewrite test with
JUnit 4 rules including
- // TemporaryFolder
+ @Category(FlakyTest.class)
Review comment:
Why remove this comment? Seems helpful to understand why the test was
marked flaky.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Upgrade to the latest dependencies
> ----------------------------------
>
> Key: GEODE-4030
> URL: https://issues.apache.org/jira/browse/GEODE-4030
> Project: Geode
> Issue Type: Bug
> Components: build, logging, rest (admin), rest (dev)
> Reporter: Swapnil Bawaskar
> Assignee: Swapnil Bawaskar
> Fix For: 1.4.0
>
>
> We need to update the following dependencies:
> {noformat}
> name from to
> ------------------------------------------------------------
> Jackson 2.8.6 2.9.2
> log4j2 2.8.2 2.10.0
> spring 4.3.6 4.3.13
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
