[
https://issues.apache.org/jira/browse/GEODE-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300329#comment-16300329
]
ASF GitHub Bot commented on GEODE-4098:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #169: GEODE-4098, add
mutex timeout
URL: https://github.com/apache/geode-native/pull/169#discussion_r158333994
##########
File path: cppcache/src/ClientMetadataService.cpp
##########
@@ -143,7 +143,12 @@ void ClientMetadataService::getClientPRMetadata(const
char* regionFullPath) {
reply.getFpaSet());
if (m_bucketWaitTimeout > std::chrono::milliseconds::zero() &&
reply.getNumBuckets() > 0) {
- WriteGuard guard(m_PRbucketStatusLock);
+ std::unique_lock<std::timed_mutex> guard(m_timedBucketStatusLock,
+ std::chrono::seconds(60));
Review comment:
Why 60 seconds here where all the other uses is 1 second and uses a
`constexpr`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Mutex guarding buckets statuses container has no timeout hanldling
> ------------------------------------------------------------------
>
> Key: GEODE-4098
> URL: https://issues.apache.org/jira/browse/GEODE-4098
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Igor Barchak
> Fix For: 1.2.0
>
>
> Mutex guarding buckets statuses container has no timeout handling,in
> ClientMetadataService.cpp
> Can cause messages stuck on client
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
