[
https://issues.apache.org/jira/browse/GEODE-4163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304772#comment-16304772
]
ASF GitHub Bot commented on GEODE-4163:
---------------------------------------
upthewaterspout commented on a change in pull request #1206: GEODE-4163 clean
up DistributionManager code
URL: https://github.com/apache/geode/pull/1206#discussion_r158862507
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/DM.java
##########
@@ -461,6 +452,11 @@ void addHostedLocators(InternalDistributedMember member,
Collection<String> loca
*/
void releaseUDPMessagingForCurrentThread();
+ /**
+ * returns the type of node
+ *
+ * @return
Review comment:
Fill in the @@return to avoid javadoc warnings
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> clean up DistributionManager code
> ---------------------------------
>
> Key: GEODE-4163
> URL: https://issues.apache.org/jira/browse/GEODE-4163
> Project: Geode
> Issue Type: Bug
> Components: membership
> Reporter: Bruce Schuchardt
>
> DistributionManager has a large number of methods that are marked public but
> should be private.
> It has a lot of methods and instance variables that aren't used and a lot of
> commented-out code.
> There are also other classes that cast a DM to DistributionManager in order
> to use methods marked public instead of adding those methods to the DM
> interface.
> DistributionManager also has instance variable sprinkled throughout the file
> and lots of raw, untyped collections.
> There are also a lot of methods that have InternalDistributedMember in their
> signatures that were extracted into the DM interface. These should be
> changed to DistributedMember, the interface that most of our code should use.
> All of these problems should be fixed.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
