[
https://issues.apache.org/jira/browse/GEODE-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16304807#comment-16304807
]
ASF GitHub Bot commented on GEODE-4097:
---------------------------------------
kirklund commented on issue #1167: GEODE-4097 allow to take geode-core jar from
classpath
URL: https://github.com/apache/geode/pull/1167#issuecomment-354178456
@igorbarc @upthewaterspout I don't understand how the PR patch fixes the
issue described by GEODE-4097. If I launch GFSH and issue this command...
```java
gfsh>start locator
--classpath=/Users/klund/dev/gemfire_CLEAN/open/tmp/geode-core-1.4.0-SNAPSHOT.jar
```
...the resulting classpath is:
```
Class-Path:
/Users/klund/dev/gemfire_CLEAN/open/geode-assembly/build/install/apache-geode/lib/geode-core-1.4.0-SNAPSHOT.jar:/Users/klund/dev/gemfire_CLEAN/open/tmp/geode-core-1.4.0-SNAPSHOT.jar:/Users/klund/dev/gemfire_CLEAN/open/geode-assembly/build/install/apache-geode/lib/geode-dependencies.jar
```
No where in the above classpath do I find the string that you edited in this
PR. Your patch changes this string...
```java
"gemfire-core-8.2.0.0-SNAPSHOT.jar"
```
...but this string doesn't seem to be used.
I believe all bug fixes should provide an automated test that exposes the
bug and validates its fix. In this case, it would remove any confusion I have
about "gemfire-core-8.2.0.0-SNAPSHOT.jar" not being used.
Some additional resources that might help in writing an automated test:
1) [wiki article describing how to write GFSH acceptance
tests](https://cwiki.apache.org/confluence/display/GEODE/Test+your+application)
2) [example of writing a Regression Test that exposes a bug and validates
its
fix](https://kirklund.com/2017/12/22/testing-with-threads-using-an-executorservice/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> No way to give private fix for geode-core jar
> ---------------------------------------------
>
> Key: GEODE-4097
> URL: https://issues.apache.org/jira/browse/GEODE-4097
> Project: Geode
> Issue Type: Bug
> Components: management
> Reporter: Igor Barchak
> Fix For: 1.3.0
>
>
> No way to give private fix for geode-core jar in different path , always
> taken hard coded from %GEODE_HOME/lib
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
