[
https://issues.apache.org/jira/browse/GEODE-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308739#comment-16308739
]
ASF GitHub Bot commented on GEODE-4176:
---------------------------------------
bschuchardt opened a new pull request #1214: GEODE-4176 locator creates
"locator0view.dat" file when started with …
URL: https://github.com/apache/geode/pull/1214
…port 0
Modified the locator to ensure that the wildcard bind has occurred before
GMSLocator creates its persistent view file. I also did some code
cleanup and addressed GEODE-1243.
@upthewaterspout @PivotalSarge @galen-pivotal @WireBaron
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> locator creates "locator0view.dat" file when started with port 0
> ----------------------------------------------------------------
>
> Key: GEODE-4176
> URL: https://issues.apache.org/jira/browse/GEODE-4176
> Project: Geode
> Issue Type: Bug
> Components: membership, tests
> Reporter: Bruce Schuchardt
> Assignee: Bruce Schuchardt
>
> The locator was modified some time ago to allow unit tests to start it with
> port 0 so that it will do a wildcard bind. When that was done the startup
> sequence wasn't changed to allow the peer-to-peer TcpHandler to know the
> bound port number & so it creates its persistent view file with port 0
> instead of the bound port number. It's possible that if such a file is left
> around a subsequent test that starts a locator with port 0 will pick up an
> old locator0view.dat file and attempt to join a distributed system that no
> longer exists.
> The startup sequence needs to be modified to allow the handlers to know the
> bound port number when they are initialized.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
