[
https://issues.apache.org/jira/browse/GEODE-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310518#comment-16310518
]
ASF GitHub Bot commented on GEODE-4192:
---------------------------------------
bschuchardt opened a new pull request #1226: GEODE-4192 GetServer request
should return error if no servers found
URL: https://github.com/apache/geode/pull/1226
I modified the GetServerOperationHandler to return a failure if there are
no suitable servers. There is a new NO_AVAILABLE_SERVER error code for
this.
I altered the test for this condition to require an error response.
I altered the experimental driver to look for the new error code and
added tests in DriverConnectionTest to ensure that it's working.
@upthewaterspout @PivotalSarge @galen-pivotal @WireBaron
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> GetServer request should return error if no servers found
> ---------------------------------------------------------
>
> Key: GEODE-4192
> URL: https://issues.apache.org/jira/browse/GEODE-4192
> Project: Geode
> Issue Type: Improvement
> Components: client/server
> Reporter: Brian Baynes
>
> When a GetServer message is received but no servers are found, we should send
> back an error (rather than success and a null value for server location).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
