[
https://issues.apache.org/jira/browse/GEODE-3965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312240#comment-16312240
]
ASF GitHub Bot commented on GEODE-3965:
---------------------------------------
kirklund opened a new pull request #1232: GEODE-3965: rename
DistributionManager classes
URL: https://github.com/apache/geode/pull/1232
This PR consists of these 3 commits:
GEODE-3965: rename DistributionManager classes
* DistributionManager -> ClusterDistributionManager
* DM -> DistributionManager
* LonerDistributionManager remains LonerDistributionManager
GEODE-3965: define exceptionInThreads methods in DistributionManager
This change removes the dependency on DistributionManagerDUnitTest from
DistributedCacheTestCase.
GEODE-3965: rename and cleanup DistributionManager tests
* DistributionManagerTest -> ClusterDistributionManagerTest
* DistributionManagerDUnitTest -> ClusterDistributionManagerDUnitTest
* ConsoleDistributionManagerDUnitTest ->
ClusterDistributionManagerForAdminDUnitTest
I tried to get the test for exceptionInThreads working but it looks like any
exceptions are caught deeper and never end up visible to the
DistributionManager, so I deleted that test. The related methods in
DistributionManager should be deleted or wired up properly by whoever ends up
refactoring the contents of ClusterDistributionManager. I could potentially
undelete the test if we think it has value (it was marked with `@Ignore`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Rename DistributionManager to ClusterDistributionManager and DM to
> DistributionManager
> --------------------------------------------------------------------------------------
>
> Key: GEODE-3965
> URL: https://issues.apache.org/jira/browse/GEODE-3965
> Project: Geode
> Issue Type: Improvement
> Components: core
> Reporter: Kirk Lund
> Assignee: Kirk Lund
>
> The interface DM currently has two implementations: DistributionManager and
> LonerDistributionManager.
> I'd like to rename DistributionManager to be ClusterDistributionManager so
> the interface can be renamed as DistributionManager.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
