[ https://issues.apache.org/jira/browse/GEODE-3584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cyrille Artho updated GEODE-3584: --------------------------------- Attachment: GEODE-3584-WIP-2 Towards a self-contained patch that merges many, but not all features (specifically, the enumeration Command is one of the unmerged parts). Test code does not fully compile yet; more typecasts are needed because many chained method calls now work via the base class, which needs to be converted to a subclass if a method that is not provided by the base class is used. > Refactor ServerLauncher and LocatorLauncher to eliminate code duplication > ------------------------------------------------------------------------- > > Key: GEODE-3584 > URL: https://issues.apache.org/jira/browse/GEODE-3584 > Project: Geode > Issue Type: Improvement > Components: gfsh > Affects Versions: 1.2.0 > Reporter: Kenneth Howe > Attachments: GEODE-3584-WIP, GEODE-3584-WIP-2 > > > There is some duplication of code in the Launcher classes that can be > eliminated. Both classes have methods such as getBindAddress (called > getServerBindAddress in ServerLauncher) that could be hoisted into > AbstractLauncher class that they both extend. The same goes for the inner > State classes of the Launchers; they have methods that could be moved to > AbstractLauncher.ServiceState. -- This message was sent by Atlassian JIRA (v6.4.14#64029)