[ 
https://issues.apache.org/jira/browse/GEODE-4221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313445#comment-16313445
 ] 

ASF GitHub Bot commented on GEODE-4221:
---------------------------------------

PivotalSarge opened a new pull request #1234: GEODE-4221: Restore the ability 
to access the debugging VM.
URL: https://github.com/apache/geode/pull/1234
 
 
   Modified DUnitLauncher.getVM(int n) to again allow -1 to get at the 
debugging VM.
   
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [X] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [X] Is your initial contribution a single, squashed commit?
   
   - [X] Does `gradlew build` run cleanly?
   
   - [n/a] Have you written or updated unit tests to verify your changes?
   
   - [n/a] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to [email protected].
   
   @upthewaterspout  @jhuynh1 @nabarunnag 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Unable to debug non-controller VMs in DUnit tests
> -------------------------------------------------
>
>                 Key: GEODE-4221
>                 URL: https://issues.apache.org/jira/browse/GEODE-4221
>             Project: Geode
>          Issue Type: Bug
>          Components: tests
>            Reporter: Michael Dodge
>            Assignee: Michael Dodge
>
> An easy mechanism for debugging code that would normally run in a 
> non-controller VM in DUnit tests is to temporarily modify the test to pass 
> {{-1}} to {{Host.getVM()}} _instead of_  a non-negative VM ID as would 
> normally be used. Unfortunately, this mechanism now results in a 
> {{java.lang.ArrayIndexOutOfBoundsException}} due to changes for GEODE-3985. 
> {{DUnitLauncher.getVM(int n)}} needs to be modified to restore the use of 
> {{-1}} for debugging.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to