Michael Dodge created GEODE-4255:
------------------------------------
Summary: Remove mandatory failure on macOS for
WANConfigurationJUnitTest.test_ValidateGatewayReceiverAttributes_WrongBindAddress
Key: GEODE-4255
URL: https://issues.apache.org/jira/browse/GEODE-4255
Project: Geode
Issue Type: Bug
Components: wan
Reporter: Michael Dodge
The JUnit test
{{WANConfigurationJUnitTest.test_ValidateGatewayReceiverAttributes_WrongBindAddress}}
always fails on macOS because there is code in lines 428-430 of
{{WANConfigurationJUnitTest.java}} that calls {{fail()}} if the OS name is
{{Mac OS X}}. The preceding comment says that the mandatory failure is in
response to a change in messaging in the Yosemite release of macOS that results
in a failure in "GatewayReceiverImpl around line 167".
At a minimum, it seems like this test should just immediately return
successfully rather than always fail. (If the thinking was that always failing
would induce someone to fix the underlying problem, that obviously hasn't
worked very well so far.) Alternatively, it would be nice to verify that the
problem still exists. Ideally, the underlying problem ought to be fixed.
{noformat}
org.apache.geode.internal.cache.wan.misc.WANConfigurationJUnitTest >
test_ValidateGatewayReceiverAttributes_WrongBindAddress FAILED
java.lang.AssertionError: Failing to avoid known hang on Mac OS X.
at org.junit.Assert.fail(Assert.java:88)
at
org.apache.geode.internal.cache.wan.misc.WANConfigurationJUnitTest.test_ValidateGatewayReceiverAttributes_WrongBindAddress(WANConfigurationJUnitTest.java:429)
{noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
