[
https://issues.apache.org/jira/browse/GEODE-3588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317382#comment-16317382
]
ASF GitHub Bot commented on GEODE-3588:
---------------------------------------
bschuchardt opened a new pull request #1255: GEODE-3588 2 restarts of Locator
results in split brain
URL: https://github.com/apache/geode/pull/1255
Udo's fix for GEODE-870 added a new boolean instance variable to
GMSJoinLeave to tell its ViewCreator thread to shut down. This works
but the state was never being reset after its first use. This caused
Subsequent ViewCreator threads to shut down immediately. The only
way to fix this condition without a patch is to restart the coordinator node.
The patch moves this boolean variable to the ViewCreator thread so that
it is automatically reset when a new ViewCreator is instantiated.
I also did a little code cleanup, moving GMSJoinLeave methods from the
end of the file to where its other methods are located and adding
a setShutdownFlag() method during debugging so I could isolate what
was happening.
@galen-pivotal @upthewaterspout @PivotalSarge @kohlmu-pivotal
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [n/a] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> 2 restarts of Locator results in split brain
> --------------------------------------------
>
> Key: GEODE-3588
> URL: https://issues.apache.org/jira/browse/GEODE-3588
> Project: Geode
> Issue Type: Bug
> Components: locator, membership
> Reporter: Michael Martell
> Attachments: RunLocalhostGemfire.ps1
>
>
> Restarting the locator and listing members works properly. Repeating the
> process a second time shows no cluster members.
> To repro:
> 1) start a locator
> 2) start a server
> 3) list members (shows locator and server)
> 4) stop the locator
> 5) restart the locator (same as step 1)
> 6) list members (shows locator and server)
> 7) stop the locator a second time
> 8) restart the locator a second time (same as step 1)
> 9) list members shows only the locator
> Notes:
> - This was done on a Windows machine using latest geode/develop (as of
> 9/11/2017)
> - Was tried with and without using protobuf=true flag, and fails in both
> cases)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
