[
https://issues.apache.org/jira/browse/GEODE-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brian Rowe resolved GEODE-4145.
-------------------------------
Resolution: Fixed
Assignee: Brian Rowe
Fix Version/s: 1.4.0
> Clean up error code handling in protobuf
> ----------------------------------------
>
> Key: GEODE-4145
> URL: https://issues.apache.org/jira/browse/GEODE-4145
> Project: Geode
> Issue Type: Task
> Components: client/server
> Reporter: Brian Rowe
> Assignee: Brian Rowe
> Fix For: 1.4.0
>
>
> We currently have some unused error codes in ProtocolErrorCode:
> UNSUPPORTED_VERSION(1101),
> HANDSHAKE_REQUIRED(1104),
> LOW_MEMORY(1300), <-- maybe this one should be used?
> BAD_QUERY(2001),
> QUERY_PARAMETER_MISMATCH(2200),
> QUERY_BIND_FAILURE(2201),
> QUERY_NOT_PERMITTED(2202),
> QUERY_TIMEOUT(2203);
> We also have a strange and incomplete list of exceptions that we catch and in
> some cases incorrectly map to some of these error codes. For example
> GetAllRequestOperationHandler catches "CacheLoaderException" and reports that
> as DATA_UNREACHABLE, which is not what a CacheLoaderException means.
> We need to review the exceptions we catch and the error codes we want to
> support and clean them up consistently across all operations.
> We may want to change the default behavior for unknown exceptions - it seems
> like maybe we just close the connection to the client without reporting the
> error message to the client for exceptions we haven't handled.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
