[ 
https://issues.apache.org/jira/browse/GEODE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321631#comment-16321631
 ] 

ASF GitHub Bot commented on GEODE-4225:
---------------------------------------

jinmeiliao closed pull request #1266: GEODE-4225: getVM(n) call does not 
accidentally bounce the VM with current version
URL: https://github.com/apache/geode/pull/1266
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/geode-core/src/test/java/org/apache/geode/test/dunit/rules/ClusterStartupRule.java
 
b/geode-core/src/test/java/org/apache/geode/test/dunit/rules/ClusterStartupRule.java
index dc79bea0bb..a4847282ed 100644
--- 
a/geode-core/src/test/java/org/apache/geode/test/dunit/rules/ClusterStartupRule.java
+++ 
b/geode-core/src/test/java/org/apache/geode/test/dunit/rules/ClusterStartupRule.java
@@ -373,7 +373,7 @@ public VM getVM(int index, String version) {
   }
 
   public VM getVM(int index) {
-    return getVM(index, VersionManager.CURRENT_VERSION);
+    return getHost(0).getVM(index);
   }
 
   public void stopVM(int index) {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Extend ClusterStartupRule to instantiate members and clients of a particular 
> version
> ------------------------------------------------------------------------------------
>
>                 Key: GEODE-4225
>                 URL: https://issues.apache.org/jira/browse/GEODE-4225
>             Project: Geode
>          Issue Type: Improvement
>            Reporter: Patrick Rhomberg
>            Assignee: Patrick Rhomberg
>
> Many tests, particularly those testing rolling upgrade, would benefit from 
> the consistency of the ClusterStartupRule but require clients of a specific 
> version.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to