[
https://issues.apache.org/jira/browse/GEODE-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322686#comment-16322686
]
Barry Oglesby commented on GEODE-4251:
--------------------------------------
This behavior doesn't exist in 8.2.
In 8.2, if the CacheClientNotifier found an existing non-durable
CacheClientProxy, it just closed it.
This commit for GEODE-1183 added this test: {{if
(staleClientProxy.isConnected() && staleClientProxy.getSocket().isConnected())}}
https://gitbox.apache.org/repos/asf?p=geode.git;a=commit;h=51e4e71ef1ffb2fddb3ade42e0ad46fe40886239
Also, there isn't an API from the client to cause its CacheClientProxy to be
closed on the server. Currently that happens either as a result of the last
client's ServerConnection going away, or as a result of the Message Dispatcher
realizing the client is gone. We'd have to add a client/server operation to
handle this.
If I add a client ping call like below to the server when its in this state,
the first one succeeds, but the second one fails.
{noformat}
if (staleClientProxy != null) {
proxy.sendMessageDirectly(new ClientPingMessageImpl());
proxy.sendMessageDirectly(new ClientPingMessageImpl());
...
{noformat}
I added some custom logging which showed:
Logging for first ping:
{noformat}
Client Queue Initialization Thread 0: CacheClientNotifier.registerClient
staleClientProxy=CacheClientProxy[identity(192.168.2.6(client:46351:loner):59351:3c907fe2:client,connection=2;
port=59357; primary=true; version=GEODE 1.4.0]
Client Queue Initialization Thread 0: CacheClientNotifier.registerClient about
to ping existing proxy
Client Queue Initialization Thread 0: MessageDispatcher.sendMessage sending
message=type=SERVER_TO_CLIENT_PING
Client Queue Initialization Thread 0: Message.flushBuffer about to write len=17
Client Queue Initialization Thread 0: Message.flushBuffer wrote len=17
Client Queue Initialization Thread 0: MessageDispatcher.sendMessage sent
message=type=SERVER_TO_CLIENT_PING
Client Queue Initialization Thread 0: CacheClientNotifier.registerClient done
ping existing proxy
{noformat}
Logging for second ping:
{noformat}
Client Queue Initialization Thread 0: CacheClientNotifier.registerClient about
to ping existing proxy
Client Queue Initialization Thread 0: MessageDispatcher.sendMessage sending
message=type=SERVER_TO_CLIENT_PING
Client Queue Initialization Thread 0: Message.flushBuffer about to write len=17
Client Queue Initialization Thread 0: MessageDispatcher.sendMessageDirectly
e=java.net.SocketException: Broken pipe (Write failed)
Client Queue Initialization Thread 0: MessageDispatcher.stopDispatching invoked
Client Queue Initialization Thread 0: CacheClientProxy.closeSocket invoked
Client Queue Initialization Thread 0: CacheClientNotifier.registerClient done
ping existing proxy
{noformat}
> [CI Failure]Class
> org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysPRDUnitTest
> --- testRegisterCreatesInvalidEntry
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GEODE-4251
> URL: https://issues.apache.org/jira/browse/GEODE-4251
> Project: Geode
> Issue Type: Bug
> Components: cq
> Reporter: nabarun
>
> {noformat}
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysDUnitTest$$Lambda$28/1575286050.run
> in VM 3 running on Host ea663fe20602 with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:393)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:363)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:308)
> at
> org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysDUnitTest.testRegisterCreatesInvalidEntry(RegisterInterestKeysDUnitTest.java:135)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:114)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:57)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:66)
> at
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
> at
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:109)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:147)
> at
> org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:129)
> at
> org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:404)
> at
> org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63)
> at
> org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:46)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: java.lang.AssertionError: failed while registering interest
> at org.apache.geode.test.dunit.Assert.fail(Assert.java:66)
> at
> org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysDUnitTest.registerKeysK1(RegisterInterestKeysDUnitTest.java:224)
> at
> org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysDUnitTest.lambda$testRegisterCreatesInvalidEntry$bb17a952$2(RegisterInterestKeysDUnitTest.java:135)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at hydra.MethExecutor.executeObject(MethExecutor.java:244)
> at
> org.apache.geode.test.dunit.standalone.RemoteDUnitVM.executeMethodOnObject(RemoteDUnitVM.java:70)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:357)
> at sun.rmi.transport.Transport$1.run(Transport.java:200)
> at sun.rmi.transport.Transport$1.run(Transport.java:197)
> at java.security.AccessController.doPrivileged(Native Method)
> at sun.rmi.transport.Transport.serviceCall(Transport.java:196)
> at
> sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:568)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:826)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:683)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:682)
> ... 3 more
> Caused by: org.apache.geode.cache.NoSubscriptionServersAvailableException:
> org.apache.geode.cache.NoSubscriptionServersAvailableException: Primary
> discovery failed.
> at
> org.apache.geode.cache.client.internal.QueueManagerImpl.getAllConnections(QueueManagerImpl.java:190)
> at
> org.apache.geode.cache.client.internal.OpExecutorImpl.executeOnQueuesAndReturnPrimaryResult(OpExecutorImpl.java:558)
> at
> org.apache.geode.cache.client.internal.PoolImpl.executeOnQueuesAndReturnPrimaryResult(PoolImpl.java:842)
> at
> org.apache.geode.cache.client.internal.RegisterInterestListOp.execute(RegisterInterestListOp.java:47)
> at
> org.apache.geode.cache.client.internal.ServerRegionProxy.registerInterestList(ServerRegionProxy.java:533)
> at
> org.apache.geode.internal.cache.LocalRegion.processSingleInterest(LocalRegion.java:3761)
> at
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3846)
> at
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3840)
> at
> org.apache.geode.internal.cache.LocalRegion.registerInterest(LocalRegion.java:3835)
> at
> org.apache.geode.internal.cache.tier.sockets.RegisterInterestKeysDUnitTest.registerKeysK1(RegisterInterestKeysDUnitTest.java:213)
> ... 24 more
> Caused by: org.apache.geode.cache.NoSubscriptionServersAvailableException:
> Primary discovery failed.
> at
> org.apache.geode.cache.client.internal.QueueManagerImpl$ConnectionList.setPrimaryDiscoveryFailed(QueueManagerImpl.java:1351)
> at
> org.apache.geode.cache.client.internal.QueueManagerImpl.recoverPrimary(QueueManagerImpl.java:965)
> at
> org.apache.geode.cache.client.internal.QueueManagerImpl$RedundancySatisfierTask.run2(QueueManagerImpl.java:1467)
> at
> org.apache.geode.cache.client.internal.PoolImpl$PoolTask.run(PoolImpl.java:1326)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
> ... 3 more
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
