[
https://issues.apache.org/jira/browse/GEODE-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327364#comment-16327364
]
ASF GitHub Bot commented on GEODE-4280:
---------------------------------------
bschuchardt commented on a change in pull request #1274: GEODE-4280 add the
ability to close a Driver and to see if the driver…
URL: https://github.com/apache/geode/pull/1274#discussion_r161817426
##########
File path:
geode-experimental-driver/src/test/java/org/apache/geode/experimental/driver/DriverConnectionTest.java
##########
@@ -96,6 +94,18 @@ public void driverCanConnectWhenThereAreServers() throws
Exception {
server.setPort(0);
server.start();
driver = new DriverFactory().addLocator("localhost", locatorPort).create();
+ assertTrue(driver.isConnected());
+ }
+
+ @Test
+ public void driverReportsItIsDisconnected() throws Exception {
+ CacheServer server = cache.addCacheServer();
+ server.setPort(0);
+ server.start();
+ driver = new DriverFactory().addLocator("localhost", locatorPort).create();
+ driver.close();
Review comment:
Oh, wait! I already have that check in driverCanConnectWhenThereAreServers.
Do you think I also need it in this test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> add the ability to close a Driver and to see if the driver is usable
> --------------------------------------------------------------------
>
> Key: GEODE-4280
> URL: https://issues.apache.org/jira/browse/GEODE-4280
> Project: Geode
> Issue Type: Bug
> Components: client/server
> Reporter: Bruce Schuchardt
> Assignee: Bruce Schuchardt
> Priority: Major
> Labels: pull-request-available
>
> I can create a protobuf Driver and use it but if it becomes disconnected I
> have no way of knowing without attempting an operation.
> I'd also like to be able to close a Driver, rendering it unusable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
