[ https://issues.apache.org/jira/browse/GEODE-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329610#comment-16329610 ]
Kenneth Howe edited comment on GEODE-4183 at 1/17/18 10:49 PM: --------------------------------------------------------------- The definition of ServerLauncher.Command Looks correct to me. SERVER_BIND_ADDRESS is not a ServerLauncher command. It is one of the options to START command, and resolves to org.apache.geode.distributed.ConfigurationProperties.SERVER_BIND_ADDRESS = "server-bind-address" was (Author: khowe): The definition of ServerLauncher.Command Looks correct to me. SERVER_BIND_ADDRESS is not a ServerLauncher command. It is on of the options to START command, and resolves to org.apache.geode.distributed.ConfigurationProperties.SERVER_BIND_ADDRESS = "server-bind-address" > Code review found likely bug regarding options/help in ServerLauncher > --------------------------------------------------------------------- > > Key: GEODE-4183 > URL: https://issues.apache.org/jira/browse/GEODE-4183 > Project: Geode > Issue Type: Bug > Components: client/server > Affects Versions: 1.4.0 > Reporter: Cyrille Artho > Assignee: Kenneth Howe > Priority: Minor > Labels: patch > Attachments: server-launcher-typo.patch > > > Both geode.distributed.LocatorLauncher and ServerLauncher have an enumeration > "Command", which contains a list of available command types and their options. > In ServerLauncher, it looks like a typo causes the help/option screens to > show incorrect information: > public enum Command { > START("start", "assign-buckets", "disable-default-server", "rebalance", > SERVER_BIND_ADDRESS, > "server-port", "force", "debug", "help"), > In these lines, "SERVER_BIND_ADDRESS" is nested within "START" rather than a > command of its own. > I'm not sure what the output should be, and no tests currently covers that > behavior. Therefore, a patch passes the tests, but so does the unchanged code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)