[
https://issues.apache.org/jira/browse/GEODE-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329716#comment-16329716
]
ASF GitHub Bot commented on GEODE-4307:
---------------------------------------
upthewaterspout opened a new pull request #1299: GEODE-4307: Removing some
static calls to GemFireCacheImpl.getForPDX
URL: https://github.com/apache/geode/pull/1299
Removing the easier static calls to getForPdx.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove static calls to GemFireCacheImpl.getForPdx
> -------------------------------------------------
>
> Key: GEODE-4307
> URL: https://issues.apache.org/jira/browse/GEODE-4307
> Project: Geode
> Issue Type: Sub-task
> Components: serialization
> Reporter: Dan Smith
> Assignee: Dan Smith
> Priority: Major
> Labels: pull-request-available
>
> GemFireCacheImpl actually has *two* static instance variables - on called
> instance and the other called pdxInstance.
> It's bad enough that we have one static instance variable, but this
> pdxVariable seems to be a hack to avoid race conditions related to shutting
> down the cache.
> If the places that need to call getForPdx can just use a cache that they
> already have access to, they won't need this hack.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
