[
https://issues.apache.org/jira/browse/GEODE-3391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330644#comment-16330644
]
ASF GitHub Bot commented on GEODE-3391:
---------------------------------------
dgkimura commented on a change in pull request #188: GEODE-3391: Update
Transaction id to pass by references
URL: https://github.com/apache/geode-native/pull/188#discussion_r162376844
##########
File path: cppcache/include/geode/CacheTransactionManager.hpp
##########
@@ -173,15 +173,15 @@ class _GEODE_EXPORT CacheTransactionManager {
* @since 3.6.2
* @see #isSuspended(TransactionId)
*/
- virtual bool exists(std::shared_ptr<TransactionId> transactionId) = 0;
+ virtual bool exists(TransactionId& transactionId) = 0;
Review comment:
I agree that would be nicer. And originally that was my plan too. However,
I think problem I ran into was that `TransactionId` is an abstraction and
actual class being passed is `TXId`. If you'd like, I can investigate meaning
behind this abstraction and whether it can be dropped and then make change to
value type accordingly. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> eval shared_ptr usage in
> CacheListener/CacheLoader/CacheTransactionMgr/CacheWriter
> ----------------------------------------------------------------------------------
>
> Key: GEODE-3391
> URL: https://issues.apache.org/jira/browse/GEODE-3391
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Ernest Burghardt
> Priority: Major
> Labels: pull-request-available
>
> evaluate shared_ptr usage and change to reference
> virtual void afterRegionDisconnected(Region& region)
> virtual CacheablePtr load(Region& rp, const CacheableKeyPtr& key,
> const UserDataPtr& aCallbackArgument) = 0;
> virtual void close(Region& rp);
> virtual void resume(const TransactionId& transactionId)
> virtual const TransactionId& getTransactionId() = 0;
> virtual void close(Region& rp);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
