[
https://issues.apache.org/jira/browse/GEODE-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331423#comment-16331423
]
ASF GitHub Bot commented on GEODE-427:
--------------------------------------
kirklund commented on a change in pull request #1307: GEODE-427: Prevent out of
order message processing
URL: https://github.com/apache/geode/pull/1307#discussion_r162501600
##########
File path:
geode-core/src/test/java/org/apache/geode/cache/management/MemoryThresholdsDUnitTest.java
##########
@@ -522,17 +521,29 @@ public Object call() throws Exception {
verifyListenerValue(server1, MemoryState.EVICTION, 2, true);
verifyListenerValue(server1, MemoryState.NORMAL, 1, true);
- LogWriterUtils.getLogWriter().info("before NORMAL->CRITICAL->NORMAL");
- // NORMAL -> EVICTION -> NORMAL
- server2.invoke(new SerializableCallable("NORMAL->CRITICAL->NORMAL") {
+ // NORMAL -> CRITICAL
+ server2.invoke(new SerializableCallable("NORMAL->CRITICAL") {
public Object call() throws Exception {
GemFireCacheImpl gfCache = (GemFireCacheImpl) getCache();
gfCache.getInternalResourceManager().getHeapMonitor().updateStateAndSendEvent(950);
+ return null;
+ }
+ });
+
+ verifyListenerValue(server2, MemoryState.CRITICAL, 2, true);
+ verifyListenerValue(server2, MemoryState.EVICTION, 3, true);
+ verifyListenerValue(server2, MemoryState.NORMAL, 1, true);
+ verifyListenerValue(server1, MemoryState.CRITICAL, 2, true);
+ verifyListenerValue(server1, MemoryState.EVICTION, 3, true);
+ verifyListenerValue(server1, MemoryState.NORMAL, 1, true);
+
+ server2.invoke(new SerializableCallable("CRITICAL->NORMAL") {
+ public Object call() throws Exception {
+ GemFireCacheImpl gfCache = (GemFireCacheImpl) getCache();
Review comment:
Recommend changing from GemFireCacheImpl to InternalCache. The
getInternalResourceManager method should exist on InternalCache.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> CI failure: MemoryThresholdsDUnitTest.testEventDelivery
> -------------------------------------------------------
>
> Key: GEODE-427
> URL: https://issues.apache.org/jira/browse/GEODE-427
> Project: Geode
> Issue Type: Bug
> Reporter: Kirk Lund
> Assignee: Nick Reich
> Priority: Major
> Labels: CI, Flaky, pull-request-available
>
> {noformat}
> dunit.RMIException: While invoking
> com.gemstone.gemfire.cache.management.MemoryThresholdsDUnitTest$56.call in VM
> 0 running on Host venezuela.gemstone.com with 4 VMs
> at dunit.VM.invoke(VM.java:360)
> at dunit.VM.invoke(VM.java:303)
> at dunit.VM.invoke(VM.java:271)
> at
> com.gemstone.gemfire.cache.management.MemoryThresholdsDUnitTest.verifyListenerValue(MemoryThresholdsDUnitTest.java:1457)
> at
> com.gemstone.gemfire.cache.management.MemoryThresholdsDUnitTest.testEventDelivery(MemoryThresholdsDUnitTest.java:467)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at junit.framework.TestCase.runTest(TestCase.java:176)
> at junit.framework.TestCase.runBare(TestCase.java:141)
> at junit.framework.TestResult$1.protect(TestResult.java:122)
> at junit.framework.TestResult.runProtected(TestResult.java:142)
> at junit.framework.TestResult.run(TestResult.java:125)
> at junit.framework.TestCase.run(TestCase.java:129)
> at junit.framework.TestSuite.runTest(TestSuite.java:252)
> at junit.framework.TestSuite.run(TestSuite.java:247)
> at
> org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.runTestClass(JUnitTestClassExecuter.java:86)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecuter.execute(JUnitTestClassExecuter.java:49)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassProcessor.processTestClass(JUnitTestClassProcessor.java:64)
> at
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:50)
> at sun.reflect.GeneratedMethodAccessor219.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.messaging.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at
> org.gradle.messaging.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
> at
> org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:106)
> at sun.reflect.GeneratedMethodAccessor218.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.messaging.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.messaging.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:360)
> at
> org.gradle.internal.concurrent.DefaultExecutorFactory$StoppableExecutorImpl$1.run(DefaultExecutorFactory.java:64)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: junit.framework.AssertionFailedError: Event never occurred after
> 5000 ms: Remote CRITICAL assert failed TestListenerStatus: normalCalls :1
> allCalls :3 criticalThresholdCalls :1 evictionThresholdCalls :2
> previousNormalCalls :1 bytesFromThreshold :50 currentHeapPercentage :75
> evictionDisabledCalls :0 criticalDisabledCalls :0
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.TestCase.fail(TestCase.java:227)
> at
> dunit.DistributedTestCase.waitForCriterion(DistributedTestCase.java:1162)
> at
> com.gemstone.gemfire.cache.management.MemoryThresholdsDUnitTest$56.call(MemoryThresholdsDUnitTest.java:1546)
> at sun.reflect.GeneratedMethodAccessor306.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at hydra.MethExecutor.executeObject(MethExecutor.java:258)
> at
> dunit.standalone.RemoteDUnitVM.executeMethodOnObject(RemoteDUnitVM.java:68)
> at sun.reflect.GeneratedMethodAccessor45.invoke(Unknown Source)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:323)
> at sun.rmi.transport.Transport$1.run(Transport.java:200)
> at sun.rmi.transport.Transport$1.run(Transport.java:197)
> at java.security.AccessController.doPrivileged(Native Method)
> at sun.rmi.transport.Transport.serviceCall(Transport.java:196)
> at
> sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:568)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:826)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$241(TCPTransport.java:683)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler$$Lambda$1/1270910893.run(Unknown
> Source)
> at java.security.AccessController.doPrivileged(Native Method)
> at
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:682)
> ... 3 more
> {noformat}
> Previously run tests: [CompressionCacheConfigDUnitTest,
> CompressionCacheListenerOffHeapDUnitTest,
> CompressionRegionOperationsOffHeapDUnitTest, CompressionStatsDUnitTest,
> ClientServerTimeSyncDUnitTest, CacheRegionClearStatsDUnitTest,
> ConnectionPoolAndLoaderDUnitTest, ClientServerRegisterInterestsDUnitTest,
> SSLNoClientAuthDUnitTest, AutoConnectionSourceDUnitTest,
> AutoConnectionSourceWithUDPDUnitTest, CacheServerSSLConnectionDUnitTest,
> LocatorLoadBalancingDUnitTest, SnapshotPerformanceDUnitTest,
> SnapshotByteArrayDUnitTest, ParallelSnapshotDUnitTest, SnapshotDUnitTest,
> PartitionRegionHelperDUnitTest, PartitionManagerDUnitTest,
> MemoryThresholdsDUnitTest]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
