[
https://issues.apache.org/jira/browse/GEODE-4309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332829#comment-16332829
]
ASF GitHub Bot commented on GEODE-4309:
---------------------------------------
PurelyApplied commented on issue #1313: GEODE-4309: Refactor ArgumentRedactor
for improved robustness.
URL: https://github.com/apache/geode/pull/1313#issuecomment-359071911
There is a mild-mannered change in behavior here: obfuscation occurs as it
should, but formatting is now consistent with the input. The former behavior
was that everything is output as a `option=value` format.
I captured the separator while iterating towards this solution. If a
consistent `option-value` is preferred, it would be a trivial update to
`ArgumentRedactor:84`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> ArgumentRedactor is not properly applied to System Properties
> -------------------------------------------------------------
>
> Key: GEODE-4309
> URL: https://issues.apache.org/jira/browse/GEODE-4309
> Project: Geode
> Issue Type: Bug
> Components: logging, security
> Affects Versions: 1.2.1
> Reporter: Patrick Rhomberg
> Assignee: Patrick Rhomberg
> Priority: Major
> Labels: pull-request-available
>
> The System Properties section of {{Banner.java}} contains the line
> {noformat}
> out.println(" " + key + " = " +
> ArgumentRedactor.redact(String.valueOf(me.getValue())));
> {noformat}
> However, the method {{redact}} excepts the entire line, not only the value,
> to determine if the entry should be redacted.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
