[ https://issues.apache.org/jira/browse/GEODE-3570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336156#comment-16336156 ]
Jacob S. Barrett edited comment on GEODE-3570 at 1/23/18 6:18 PM: ------------------------------------------------------------------ RegionAttributes for expiration treat zero duration as no timeout, all other durations timeout at 1 second resolution. PoolFactory::setFreeConnectionTimeout takes a duration with resolution of 1ms. Values 0 or less are not allowed. PoolFactory::setReadTimeout takes a duration with resolution of 1ms. Values 0 or less are not allowed. *PoolFactory::setIdleTimeout documents use -1ms to disable feature. Zero duration is undefined. Suggest this changes to 0 duration for disable.* PoolFactory::setPingInterval takes a duration with resolution of 1ms. Values 0 or less are not allowed. PoolFactory::setSubscriptionMessageTrackingTimeout takes a duration with resolution of 1ms. Values 0 or less are not allowed. PoolFactory::setSubscriptionAckInterval takes a duration with resolution of 1ms. Values 0 or less are not allowed. *PoolFactory::setLoadConditioningInterval documents use -1ms to disable feature. Zero duration is undefined. Suggest this changes to 0 duration for disable. Currently Values 0 or less are not allowed.* *PoolFactory::setStatisticInterval* *documents use -1ms to disable feature. Zero duration is undefined. Suggest this changes to 0 duration for disable. Currently Values 0 or less are not allowed.* CacheTransactionManager::tryResume is overloaded with timeout option. CqQuery::executeWithInitialResults takes a duration with resolution of 1ms with limit of 2^31-1. Values 0 or less are not defined. ResultCollector::getResult takes a duration with resolution of 1ms. Values less than 0 are not defined. Execution::execute takes a duration with 1ms resolution with limit of 2^31-1. Values of 0 or less are not defined. Execution::putAll/selectValue/query/existsValue takes a duration with 1ms resolution with limit of 2^31-1. Values of 0 or less are not defined. SystemProperties::statisticsSampleInterval takes a duration with 1ms resolution. Values of 0 or less are not defined. SystemProperties::pingInterval takes a duration with 1s resolution. Values of 0 or less are not defined. SystemProperties::redundancyMonitorInterval takes a duration with 1s resolution. Values of 0 or less are not defined. SystemProperties::notifyAckInterval takes a duration with 1ms resolution. Values of 0 or less are not defined. SystemProperties::notifyDupCheckLife takes a duration with 1ms resolution. Values of 0 or less are not defined. SystemProperties::durableTimeout takes a duration with 1s resolution. Values of 0 or less are not defined. SystemProperties::connectTimeout takes a duration with 1ms resolution. Values of 0 or less are not defined. SystemProperties::connectWaitTimeout takes a duration with 1ms resolution. Values of 0 or less are not defined. SystemProperties::bucketWaitTimeout takes a duration with 1ms resolution. Values of 0 or less are not defined. SystemProperties::suspendedTxTimeout takes a duration with 1s resolution. Values of 0 or less are not defined. SystemProperties::tombstoneTimeout takes a duration with 1ms resolution. Values of 0 or less are not defined. was (Author: jbarrett): RegionAttributes for expiration treat zero duration as no timeout, all other durations timeout at 1 second resolution. PoolFactory::setFreeConnectionTimeout takes a duration with resolution of 1ms. Values 0 or less are not allowed. PoolFactory::setReadTimeout takes a duration with resolution of 1ms. Values 0 or less are not allowed. PoolFactory::setIdleTimeout takes a duration with resolution of 1ms. Zero disables. Values less than 0 undefined. PoolFactory::setPingInterval takes a duration with resolution of 1ms. Values 0 or less are not allowed. PoolFactory::setSubscriptionMessageTrackingTimeout takes a duration with resolution of 1ms. Values 0 or less are not allowed. PoolFactory::setSubscriptionAckInterval takes a duration with resolution of 1ms. Values 0 or less are not allowed. *PoolFactory::setLoadConditioningInterval documents use -1ms to disable feature. Zero duration is undefined. Suggest this changes to 0 duration for disable. Currently Values 0 or less are not allowed.* *PoolFactory::setStatisticInterval* *documents use -1ms to disable feature. Zero duration is undefined. Suggest this changes to 0 duration for disable. Currently Values 0 or less are not allowed.* CacheTransactionManager::tryResume is overloaded with timeout option. CqQuery::executeWithInitialResults takes a duration with resolution of 1ms with limit of 2^31-1. Values 0 or less are not defined. ResultCollector::getResult takes a duration with resolution of 1ms. Values less than 0 are not defined. Execution::execute takes a duration with 1ms resolution with limit of 2^31-1. Values of 0 or less are not defined. Execution::putAll/selectValue/query/existsValue takes a duration with 1ms resolution with limit of 2^31-1. Values of 0 or less are not defined. SystemProperties::statisticsSampleInterval takes a duration with 1ms resolution. Values of 0 or less are not defined. SystemProperties::pingInterval takes a duration with 1s resolution. Values of 0 or less are not defined. SystemProperties::redundancyMonitorInterval takes a duration with 1s resolution. Values of 0 or less are not defined. SystemProperties::notifyAckInterval takes a duration with 1ms resolution. Values of 0 or less are not defined. SystemProperties::notifyDupCheckLife takes a duration with 1ms resolution. Values of 0 or less are not defined. SystemProperties::durableTimeout takes a duration with 1s resolution. Values of 0 or less are not defined. SystemProperties::connectTimeout takes a duration with 1ms resolution. Values of 0 or less are not defined. SystemProperties::connectWaitTimeout takes a duration with 1ms resolution. Values of 0 or less are not defined. SystemProperties::bucketWaitTimeout takes a duration with 1ms resolution. Values of 0 or less are not defined. SystemProperties::suspendedTxTimeout takes a duration with 1s resolution. Values of 0 or less are not defined. SystemProperties::tombstoneTimeout takes a duration with 1ms resolution. Values of 0 or less are not defined. > Standardize on model for infinity that doesn't use int overloading > ------------------------------------------------------------------ > > Key: GEODE-3570 > URL: https://issues.apache.org/jira/browse/GEODE-3570 > Project: Geode > Issue Type: Improvement > Components: native client > Reporter: Mark Hanson > Assignee: Jacob S. Barrett > Priority: Major > > See discussion here http://markmail.org/thread/hwrkg5cra57lyvo3 > Currently the code in the native client follows various conventions. We would > like to standardize the code to use a model where instead of overloading int > to mean infinity on a wait, to create two separate function calls. One for > wait indefinitely wait() and one to wait for a duration > waitDuration(duration) > ThinClientRegion.cpp:2996 executeFunction needs refactoring. > PoolAttributes.hpp:69 setRetryAttempts needs to be retitled attempts and then > the using functions need to use it appropriately. -- This message was sent by Atlassian JIRA (v7.6.3#76005)