[
https://issues.apache.org/jira/browse/GEODE-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338404#comment-16338404
]
ASF subversion and git services commented on GEODE-4358:
--------------------------------------------------------
Commit ee9b51b3d6693a21ad95d1e8d85b331aba81b917 in geode's branch
refs/heads/develop from [~barry.oglesby]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ee9b51b ]
GEODE-4358: Added check for null updater
> If internalDestory is called on a QueueConnectionImpl followed by
> internalClose, an NPE will occur
> --------------------------------------------------------------------------------------------------
>
> Key: GEODE-4358
> URL: https://issues.apache.org/jira/browse/GEODE-4358
> Project: Geode
> Issue Type: Bug
> Components: client queues
> Reporter: Barry Oglesby
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {{QueueConnectionImpl internalDestroy}} sets {{updater = null}}, but
> {{internalClose}} does not check for null before attempting to call {{close}}
> on the updater.
> A warning like below occurs in this case:
> {noformat}
> [warning 2017/05/30 20:13:55.512 PDT
> edgegemfire5_rs-qnqTesting-client-7_27065 <queueTimer-edgeDescript> tid=0xc3]
> Error destroying client to server connection to rs-qnqTesting-client-7:20606
> java.lang.NullPointerException
> at
> org.apache.geode.cache.client.internal.QueueConnectionImpl.internalClose(QueueConnectionImpl.java:76)
> at
> org.apache.geode.cache.client.internal.QueueManagerImpl.addToConnectionList(QueueManagerImpl.java:1031)
> at
> org.apache.geode.cache.client.internal.QueueManagerImpl.recoverPrimary(QueueManagerImpl.java:897)
> at
> org.apache.geode.cache.client.internal.QueueManagerImpl$RedundancySatisfierTask.run2(QueueManagerImpl.java:1467)
> at
> org.apache.geode.cache.client.internal.PoolImpl$PoolTask.run(PoolImpl.java:1315)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
