[
https://issues.apache.org/jira/browse/GEODE-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339631#comment-16339631
]
ASF GitHub Bot commented on GEODE-4186:
---------------------------------------
dgkimura opened a new pull request #194: GEODE-4186: Replace decayed array
paremeters with std::vector
URL: https://github.com/apache/geode-native/pull/194
_**In-Progress:**_ .NET changes.
It is probably worth noting that this change also removes support for
nullable arrays.
Testing: C++ unit/integration tests passed on Linux, Windows, and Mac
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Replace all decayed array parameters (Type *) with std::vector.
> ---------------------------------------------------------------
>
> Key: GEODE-4186
> URL: https://issues.apache.org/jira/browse/GEODE-4186
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Jacob S. Barrett
> Priority: Major
> Labels: pull-request-available
>
> Replace all decayed array parameters (Type *) with std::vector. For example
> {code}
> void writeIntArray(int32_t* array, size_t length);
> int32_t* readIntArray(size_t& length);
> {code}
> to
> {code}
> void writeIntArray(const std::vector<int32_t>& array);
> std::vector<int32_t> readIntArray();
> {code}
> This removes the ambiguity around memory ownership, makes the method
> functional (no out param), collocates the length and other array attributes
> with the vector, and removes null.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
