[ 
https://issues.apache.org/jira/browse/GEODE-3390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison closed GEODE-3390.
--------------------------

> All interfaces should use std types
> -----------------------------------
>
>                 Key: GEODE-3390
>                 URL: https://issues.apache.org/jira/browse/GEODE-3390
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Ernest Burghardt
>            Priority: Major
>
>  unless we are still keeping internal refrences to this we should
>   // return unique_ptr<>;
>   static CacheFactoryPtr createCacheFactory(
>       const PropertiesPtr& dsProps = nullptr);
> char* => std::string(s)
> evaluate int usage vs size_t (change as appropriate)
> -   CacheFactoryPtr setSocketBufferSize(uint32_t bufferSize);
> int => uint32_t
>   template <class Rep, class Period>
>   CacheFactoryPtr setStatisticInterval(
>       const std::chrono::duration<Rep, Period>& statisticInterval) {
>     // TODO GEODE-3136 - Consider 0 to disable
>     if (statisticInterval < std::chrono::duration<Rep, Period>::zero()) {
>       throw std::invalid_argument("timeout must greater than or equal to 0.");
>   CacheFactoryPtr addLocator(const std::string& host, uint16_t port);



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to