Addison created GEODE-4601:
------------------------------

             Summary: Refactor TcrMessage - resolve accessor encapsulation
                 Key: GEODE-4601
                 URL: https://issues.apache.org/jira/browse/GEODE-4601
             Project: Geode
          Issue Type: Task
          Components: native client
            Reporter: Addison


{{TcrMessage}} has accessor {{setMessageType()}} which should be removed from 
the base class.  It is used only on reply messages, _not_ request messages.

Here are some steps we can take:
# Move it into the {{TcrMessageReply}} class.
# Remove the accessor entirely by altering internal APIs, e.g. 
{{TcrMessageHelper::readChunkPartHeader()}}, to return a message object rather 
than taking a reference to a message and then modifying the type.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to