[
https://issues.apache.org/jira/browse/GEODE-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Rhomberg resolved GEODE-3952.
-------------------------------------
Resolution: Fixed
Resolved in commit {{96684f3f801998edea9d64ce0f66cc9f73621c97}}.
> Improve spotless to more closely adhere to established style guidelines.
> -------------------------------------------------------------------------
>
> Key: GEODE-3952
> URL: https://issues.apache.org/jira/browse/GEODE-3952
> Project: Geode
> Issue Type: Improvement
> Reporter: Patrick Rhomberg
> Priority: Trivial
>
> Spotless currently addresses whitespacing and very little else. It could be
> expanded to clean up the more glaring (in my opinion) broken windows. This
> includes:
> * Adherence to the established import ordering given in `[geode]/etc/`
> * Adherence to the established modifier ordering given in the Google Java
> Style guide, which we largely adopt. (e.g., `public static int` over `static
> public int`.)
> * Removal of some dead code, particularly commented-out import statements.
> * Improvements to whitespace handling, particularly to end files in a single
> carriage return and to trim whitespace from the end of each line.
> Increase to compile time is trivial, approximately ten seconds in the worst
> case.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
