[ https://issues.apache.org/jira/browse/GEODE-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383848#comment-16383848 ]
ASF subversion and git services commented on GEODE-4517: -------------------------------------------------------- Commit 7ec3956ea78ba3b3b448a0aef9d3703d8ed5a385 in geode's branch refs/heads/develop from [~prhomberg] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7ec3956 ] GEODE-4517: Remove getAnyInstancce call from CliUtil. * CliUtil.getCacheIfExists now takes supplier, but will squelch error and return null as before. * LogWriter.getInstance now explicitly takes a Cache, to hook into the cache's LogWriter. This perhaps should be replaced by the LogService logger in a future commit. * GfshExecutionStrategy adopts the Gfsh shell's LogWriter, since the shell will necessarily have finished instantiating the LogWriter's singleton before GfshExecutionStrategy can instantiate. * In some instances, the LogWriter has been replaced with the Log4j LogService logger. * Launcher explicitly passes a null Cache, since it does not yet exist. * Other minor improvements: visibility, typo corrections, etc. > Remove singleton calls from product code in > org.apache.geode.management.internal.cli > ------------------------------------------------------------------------------------ > > Key: GEODE-4517 > URL: https://issues.apache.org/jira/browse/GEODE-4517 > Project: Geode > Issue Type: Sub-task > Components: gfsh > Reporter: Kirk Lund > Priority: Major > Labels: pull-request-available > Time Spent: 2h > Remaining Estimate: 0h > > These product classes in org.apache.geode.management.internal.cli invoke > singleton getters. > CacheFactory.getAnyInstance(): > * CliUtil -- This message was sent by Atlassian JIRA (v7.6.3#76005)