[ 
https://issues.apache.org/jira/browse/GEODE-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389901#comment-16389901
 ] 

ASF subversion and git services commented on GEODE-4793:
--------------------------------------------------------

Commit 7becb7c2526b338b7cef5a73c2a3d96c1156208b in geode's branch 
refs/heads/develop from [~jens.deppe]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=7becb7c ]

GEODE-4793: Ensure that Files.list() closes resources (#1572)

- This was causing some DUnits to fail on Windows.

> DUnit tests fail on Windows
> ---------------------------
>
>                 Key: GEODE-4793
>                 URL: https://issues.apache.org/jira/browse/GEODE-4793
>             Project: Geode
>          Issue Type: Bug
>          Components: gfsh
>            Reporter: Jens Deppe
>            Assignee: Jens Deppe
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Various tests will fail on Windows with errors similar to the following:
> {noformat}
> [vm0] [error 2018/03/07 04:38:13.670 UTC <RMI TCP 
> Connection(1)-10.32.110.121> tid=19] Error occurred while initializing 
> cluster configuration
> [vm0] java.lang.RuntimeException: Error occurred while initializing cluster 
> configuration
> [vm0]         at 
> org.apache.geode.distributed.internal.ClusterConfigurationService.getConfigurationRegion(ClusterConfigurationService.java:731)
> [vm0]         at 
> org.apache.geode.distributed.internal.ClusterConfigurationService.initSharedConfiguration(ClusterConfigurationService.java:459)
> [vm0]         at 
> org.apache.geode.distributed.internal.InternalLocator.startSharedConfigurationService(InternalLocator.java:1332)
> [vm0]         at 
> org.apache.geode.distributed.internal.InternalLocator.startCache(InternalLocator.java:668)
> [vm0]         at 
> org.apache.geode.distributed.internal.InternalLocator.startDistributedSystem(InternalLocator.java:647)
> [vm0]         at 
> org.apache.geode.distributed.internal.InternalLocator.startLocator(InternalLocator.java:309)
> [vm0]         at 
> org.apache.geode.distributed.Locator.startLocator(Locator.java:253)
> [vm0]         at 
> org.apache.geode.distributed.Locator.startLocatorAndDS(Locator.java:140)
> [vm0]         at 
> org.apache.geode.test.junit.rules.LocatorStarterRule.startLocator(LocatorStarterRule.java:78)
> [vm0]         at 
> org.apache.geode.test.junit.rules.LocatorStarterRule.before(LocatorStarterRule.java:59)
> [vm0]         at 
> org.apache.geode.test.dunit.rules.ClusterStartupRule.lambda$startLocatorVM$1c67b668$1(ClusterStartupRule.java:157)
> [vm0]         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> [vm0]         at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> [vm0]         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> [vm0]         at java.lang.reflect.Method.invoke(Method.java:498)
> [vm0]         at hydra.MethExecutor.executeObject(MethExecutor.java:244)
> [vm0]         at 
> org.apache.geode.test.dunit.standalone.RemoteDUnitVM.executeMethodOnObject(RemoteDUnitVM.java:70)
> [vm0]         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> [vm0]         at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> [vm0]         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> [vm0]         at java.lang.reflect.Method.invoke(Method.java:498)
> [vm0]         at 
> sun.rmi.server.UnicastServerRef.dispatch(UnicastServerRef.java:361)
> [vm0]         at sun.rmi.transport.Transport$1.run(Transport.java:200)
> [vm0]         at sun.rmi.transport.Transport$1.run(Transport.java:197)
> [vm0]         at java.security.AccessController.doPrivileged(Native Method)
> [vm0]         at sun.rmi.transport.Transport.serviceCall(Transport.java:196)
> [vm0]         at 
> sun.rmi.transport.tcp.TCPTransport.handleMessages(TCPTransport.java:568)
> [vm0]         at 
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(TCPTransport.java:826)
> [vm0]         at 
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(TCPTransport.java:683)
> [vm0]         at java.security.AccessController.doPrivileged(Native Method)
> [vm0]         at 
> sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(TCPTransport.java:682)
> [vm0]         at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [vm0]         at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [vm0]         at java.lang.Thread.run(Thread.java:748)
> [vm0] Caused by: java.io.IOException: Cannot create directory at 
> C:\Users\Administrator\geode\geode-core\dunit\vm0\ConfigDiskDir_locator-0
> [vm0]         at 
> org.apache.geode.distributed.internal.ClusterConfigurationService.getConfigurationRegion(ClusterConfigurationService.java:699)
> [vm0]         ... 33 more
> {noformat}
> The problem boils down to the use of `Files.list` which sometimes will hold 
> open a directory and prevent its cleanup between tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to