[
https://issues.apache.org/jira/browse/GEODE-4749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405351#comment-16405351
]
Michael Dodge commented on GEODE-4749:
--------------------------------------
{{CompiledClassUtils}} may also need a little work.
> change AnalyzeSerializables to not store method bytecodes in
> sanctioned/actual files
> ------------------------------------------------------------------------------------
>
> Key: GEODE-4749
> URL: https://issues.apache.org/jira/browse/GEODE-4749
> Project: Geode
> Issue Type: Bug
> Components: serialization
> Reporter: Bruce Schuchardt
> Priority: Major
>
> AnalyzeSerializables stores a string representation of the bytecodes of the
> toData/fromData methods in sanctionedDataSerializables.txt and
> actualDataSerializables.dat but it only pays attention to the number of
> bytecodes when detecting changes to these methods. Many of the bytecode
> strings are now out of date. Though the methods have the same number of
> bytecodes the actual code generated by the compiler is different now than it
> used to be.
> We need to change the ClassAndMethodDetails class to only care about the
> number of bytecodes and not hold onto the bytes themselves. Then regenerate
> all of the sanctionedDataSerializables.txt files in the various modules (run
> the test and copy the actualDataSerializables.dat file over the
> sanctionedDataSerializables.txt file). This will help our git pull request
> diffs be compact and understandable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)