Kirk Lund created GEODE-4937:
--------------------------------

             Summary: Client tests should reference CacheClientProxy 
KEY_SLOW_START_TIME_FOR_TESTING
                 Key: GEODE-4937
                 URL: https://issues.apache.org/jira/browse/GEODE-4937
             Project: Geode
          Issue Type: Wish
          Components: tests
            Reporter: Kirk Lund


CacheClientProxy constant KEY_SLOW_START_TIME_FOR_TESTING should be made public 
so that tests can reference it instead of hardcoding "slowStartTimeForTesting" 
when enabling this (for testing only) system property.

{noformat}
$ git grep slowStartTimeForTesting
geode-core/src/main/java/org/apache/geode/internal/cache/properties.html:<dt><strong>slowStartTimeForTesting</strong></dt>
geode-core/src/main/java/org/apache/geode/internal/cache/properties.html:See 
org.apache.geode.internal.cache.tier.sockets.CacheClientProxy.MessageDispatcher#slowStartTimeForTesting.
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java:
  private static final String KEY_SLOW_START_TIME_FOR_TESTING = 
"slowStartTimeForTesting";
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java:
        long slowStartTimeForTesting =
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java:
        while ((slowStartTimeForTesting > elapsedTime) && 
isSlowStartForTesting) {
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxy.java:
        if (slowStartTimeForTesting < elapsedTime) {
geode-core/src/test/java/org/apache/geode/internal/cache/ha/Bug36853EventsExpiryDUnitTest.java:
    System.setProperty("slowStartTimeForTesting", 
String.valueOf(DISPATCHER_SLOWSTART_TIME));
geode-core/src/test/java/org/apache/geode/internal/cache/ha/HAConflationDUnitTest.java:
    System.setProperty("slowStartTimeForTesting", "15000");
geode-core/src/test/java/org/apache/geode/internal/cache/ha/HAGIIDUnitTest.java:
    System.setProperty("slowStartTimeForTesting", "120000");
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ClientConflationDUnitTest.java:
    System.setProperty("slowStartTimeForTesting", "15000");
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ConflationDUnitTest.java:
    System.setProperty("slowStartTimeForTesting", milis);
geode-cq/src/test/java/org/apache/geode/internal/cache/ha/HADispatcherDUnitTest.java:
    System.setProperty("slowStartTimeForTesting", "5000");
{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to