[ https://issues.apache.org/jira/browse/GEODE-3237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Barbara Pruijn updated GEODE-3237: ---------------------------------- Description: We should handle the error more gracefully and informatively. Currently if user did the following: gfsh> start locator --name=locator gfsh> shutdown --include-lcoator=true gfsh> start locator --name=locator --load-cluster-configuration-from-dir=true the console message says "Cluster configuration service has been started, but its not running yet", and there is an NPE in the log: [error 2017/07/18 10:22:38.357 PDT locator <Pooled Message Processor 1> tid=0x41] null java.lang.NullPointerException at org.apache.geode.distributed.internal.ClusterConfigurationService.loadSharedConfigurationFromDisk(ClusterConfigurationService.java:618) at org.apache.geode.distributed.internal.ClusterConfigurationService.initSharedConfiguration(ClusterConfigurationService.java:441) at org.apache.geode.distributed.internal.InternalLocator$SharedConfigurationRunnable.run(InternalLocator.java:613) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at org.apache.geode.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:665) at org.apache.geode.distributed.internal.DistributionManager$4$1.run(DistributionManager.java:922) at java.lang.Thread.run(Thread.java:745) The error message should be saying: You have --load-cluster-configuration-from-dir=true but have not specified --cluster-config-dir with a directory to the cluster config file. was: We should handle the error more gracefully and informatively. Currently if user did the following: gfsh> start locator --name=locator gfsh> shutdown --include-lcoator=true gfsh> start locator --name=locator --load-cluster-configuration-from-dir=true the console message says "Cluster configuration service has been started, but its not running yet", and there is an NPE in the log: [error 2017/07/18 10:22:38.357 PDT locator <Pooled Message Processor 1> tid=0x41] null java.lang.NullPointerException at org.apache.geode.distributed.internal.ClusterConfigurationService.loadSharedConfigurationFromDisk(ClusterConfigurationService.java:618) at org.apache.geode.distributed.internal.ClusterConfigurationService.initSharedConfiguration(ClusterConfigurationService.java:441) at org.apache.geode.distributed.internal.InternalLocator$SharedConfigurationRunnable.run(InternalLocator.java:613) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at org.apache.geode.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:665) at org.apache.geode.distributed.internal.DistributionManager$4$1.run(DistributionManager.java:922) at java.lang.Thread.run(Thread.java:745) the message should be saying: the CC can't be started, because the directory did not contain valid CC information. > Loading cluster configuration from a dir that does not have complete CC will > throw NPE > -------------------------------------------------------------------------------------- > > Key: GEODE-3237 > URL: https://issues.apache.org/jira/browse/GEODE-3237 > Project: Geode > Issue Type: Bug > Reporter: Jinmei Liao > Priority: Major > > We should handle the error more gracefully and informatively. Currently if > user did the following: > gfsh> start locator --name=locator > gfsh> shutdown --include-lcoator=true > gfsh> start locator --name=locator --load-cluster-configuration-from-dir=true > the console message says "Cluster configuration service has been started, but > its not running yet", > and there is an NPE in the log: > [error 2017/07/18 10:22:38.357 PDT locator <Pooled Message Processor 1> > tid=0x41] null > java.lang.NullPointerException > at > org.apache.geode.distributed.internal.ClusterConfigurationService.loadSharedConfigurationFromDisk(ClusterConfigurationService.java:618) > at > org.apache.geode.distributed.internal.ClusterConfigurationService.initSharedConfiguration(ClusterConfigurationService.java:441) > at > org.apache.geode.distributed.internal.InternalLocator$SharedConfigurationRunnable.run(InternalLocator.java:613) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at > org.apache.geode.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:665) > at > org.apache.geode.distributed.internal.DistributionManager$4$1.run(DistributionManager.java:922) > at java.lang.Thread.run(Thread.java:745) > The error message should be saying: You have > --load-cluster-configuration-from-dir=true but have not specified > --cluster-config-dir with a directory to the cluster config file. -- This message was sent by Atlassian JIRA (v7.6.3#76005)