[ 
https://issues.apache.org/jira/browse/GEODE-3237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434489#comment-16434489
 ] 

ASF subversion and git services commented on GEODE-3237:
--------------------------------------------------------

Commit 8ca39e93f2d4ef6503e3b52a68fb193bc5c3e6ac in geode's branch 
refs/heads/develop from [~sai.boorlaga...@gmail.com]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=8ca39e9 ]

GEODE-3237: Loading cluster configuration from a dir that does not ha… (#1746)

    command option --load-cluster-config-from-dir is deprecated and a warning
    is added to the gfsh command output in case if its used.


> Loading cluster configuration from a dir that does not have complete CC will 
> throw NPE
> --------------------------------------------------------------------------------------
>
>                 Key: GEODE-3237
>                 URL: https://issues.apache.org/jira/browse/GEODE-3237
>             Project: Geode
>          Issue Type: Bug
>          Components: configuration, gfsh
>            Reporter: Jinmei Liao
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> We should handle the error more gracefully and informatively. Currently if 
> user did the following:
> gfsh> start locator --name=locator
>  gfsh> shutdown --include-lcoator=true
>  gfsh> start locator --name=locator --load-cluster-configuration-from-dir=true
> the console message says "Cluster configuration service has been started, but 
> its not running yet",
>  and there is an NPE in the log:
>  [error 2017/07/18 10:22:38.357 PDT locator <Pooled Message Processor 1> 
> tid=0x41] null
>  java.lang.NullPointerException
>  at 
> org.apache.geode.distributed.internal.ClusterConfigurationService.loadSharedConfigurationFromDisk(ClusterConfigurationService.java:618)
>  at 
> org.apache.geode.distributed.internal.ClusterConfigurationService.initSharedConfiguration(ClusterConfigurationService.java:441)
>  at 
> org.apache.geode.distributed.internal.InternalLocator$SharedConfigurationRunnable.run(InternalLocator.java:613)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  at 
> org.apache.geode.distributed.internal.DistributionManager.runUntilShutdown(DistributionManager.java:665)
>  at 
> org.apache.geode.distributed.internal.DistributionManager$4$1.run(DistributionManager.java:922)
>  at java.lang.Thread.run(Thread.java:745)
> The error message if no directory is specified, should be saying:
> {code:java}
> The option load-cluster-configuration-from-dir=true is specified but the 
> option -cluster-config-dir needs to be set with a directory to the cluster 
> config file.{code}
> The error message if the directory is specified but cluster config file is 
> not found in that directory:
> {code:java}
> No cluster configuration is found in <specified directory>{code}
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to