[ 
https://issues.apache.org/jira/browse/GEODE-5064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Huynh updated GEODE-5064:
-------------------------------
    Description: 
There appears to be an exception that should be thrown, but upon futher 
inspection, this clause can never be hit because the boolean it checks is never 
set to true;

 

In LocalRegion:

logger.info("Failed to create index {} on region {} with exception: {}",
 icd.getIndexName(), this.getFullPath(), ex);

// Check if the region index creation is from cache.xml, in that case throw 
exception.
// Other case is when bucket regions are created dynamically, in that case 
ignore the
// exception.
if (internalRegionArgs.getDeclarativeIndexCreation()) {
 throw new 
InternalGemFireError(LocalizedStrings.GemFireCache_INDEX_CREATION_EXCEPTION_1
 .toLocalizedString(icd.getIndexName(), this.getFullPath()), ex);
}

  was:There appears to be an exception that should be thrown, but upon futher 
inspection, this clause can never be hit because the boolean it checks is never 
set to true;


> Remove unused code and if clause that does not get thrown
> ---------------------------------------------------------
>
>                 Key: GEODE-5064
>                 URL: https://issues.apache.org/jira/browse/GEODE-5064
>             Project: Geode
>          Issue Type: Bug
>          Components: querying
>            Reporter: Jason Huynh
>            Assignee: Jason Huynh
>            Priority: Major
>
> There appears to be an exception that should be thrown, but upon futher 
> inspection, this clause can never be hit because the boolean it checks is 
> never set to true;
>  
> In LocalRegion:
> logger.info("Failed to create index {} on region {} with exception: {}",
>  icd.getIndexName(), this.getFullPath(), ex);
> // Check if the region index creation is from cache.xml, in that case throw 
> exception.
> // Other case is when bucket regions are created dynamically, in that case 
> ignore the
> // exception.
> if (internalRegionArgs.getDeclarativeIndexCreation()) {
>  throw new 
> InternalGemFireError(LocalizedStrings.GemFireCache_INDEX_CREATION_EXCEPTION_1
>  .toLocalizedString(icd.getIndexName(), this.getFullPath()), ex);
> }



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to