ASF subversion and git services commented on GEODE-5044:

Commit 757e8f915b4fc7c6c3d637426c7015b9ade486f2 in geode's branch 
refs/heads/develop from Dan Smith
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=757e8f9 ]

GEODE-5044: Correctly log stack trace on the protobuf server

We were just logging the exception message, not the stack trace.

> Protobuf server does not log full stacktrace of failures
> --------------------------------------------------------
>                 Key: GEODE-5044
>                 URL: https://issues.apache.org/jira/browse/GEODE-5044
>             Project: Geode
>          Issue Type: Bug
>          Components: client/server
>            Reporter: Dan Smith
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>          Time Spent: 20m
>  Remaining Estimate: 0h
> While doing some testing, we noticed that the protobuf server was not logging 
> the stacktrace of some failures, which makes debugging difficult.
> Looking at the code, it looks like we were trying to log the exception as a 
> separate log line. But in this case the exception just gets turned into a 
> string
> {code:java}
> logger.error("Invalid execution context found for operation {}", requestType);
> logger.error(exception); //This just prints the toString of the exception
> {code}
> Instead, we should be logging the exception and message as a single line
> {code:java}
> logger.error("Invalid execution context found for operation {}", requestType, 
> exception);
> {code}

This message was sent by Atlassian JIRA

Reply via email to