[
https://issues.apache.org/jira/browse/GEODE-3438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16450256#comment-16450256
]
ASF subversion and git services commented on GEODE-3438:
--------------------------------------------------------
Commit 147c9d54dcc2d03704e6cb4ddfc2fa36fa70278f in geode's branch
refs/heads/develop from [~nabarunnag]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=147c9d5 ]
GEODE-3438: Removed unused constructor and method (#1832)
> Collection added to itself
> --------------------------
>
> Key: GEODE-3438
> URL: https://issues.apache.org/jira/browse/GEODE-3438
> Project: Geode
> Issue Type: Bug
> Components: querying
> Reporter: JC
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Hi
> In a recent github mirror, I've found suspicious code.
> Branch: master
> Path:
> geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DurableCqNamesResult.java
> {code:java}
> ...
> 27 private List<String> cqNames = new ArrayList<String>();
> ...
> 33 public DurableCqNamesResult(final String memberNameOrId, List<String>
> cqNames) {
> 34 super(memberNameOrId);
> 35 cqNames.addAll(cqNames);
> 36 }
> {code}
> In Line 35, should `cqNames.addAll' be `this.cqNames.addAll'? This might not
> be an issue, but I wanted to report just in case.
> Thanks!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
