[
https://issues.apache.org/jira/browse/GEODE-3563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475071#comment-16475071
]
ASF subversion and git services commented on GEODE-3563:
--------------------------------------------------------
Commit 1e8b8ba1aff46cf218f297686c5f08d594983ba1 in geode's branch
refs/heads/support/9.5 from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1e8b8ba ]
GEODE-3563 SSL socket handling problems in TCPConduit run (#1955)
Merged by:
Signed-Off-By: Galen O'Sullivan <[email protected]>
Modified the handshake method to establish a timeout and revert it when done.
Added testing to ensure the timeout is being established and honored.
> SSL socket handling problems in TCPConduit run
> ----------------------------------------------
>
> Key: GEODE-3563
> URL: https://issues.apache.org/jira/browse/GEODE-3563
> Project: Geode
> Issue Type: Bug
> Components: messaging
> Reporter: Vahram Aharonyan
> Assignee: Bruce Schuchardt
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.6.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Here are two cases that seems to problematic in TCPConduit.run flow:
> 1. TCPConduit.run() has no action performed for the case when SSLException is
> thrown from sslSocket.startHandshake(), as a result the socket remains open.
> Catch block from the end of configureServerSSLSocket() will just report a
> fatal error(even it seem that this portion is going to be removed in 1.2.1
> according to GEODE-3393) and re-throw the exception.
> 2. configureServerSSLSocket call is performed without setting socket timeout
> before that. This can bring to run thread blocking case if read initiated
> from the SSL handshake flow will not return. Linking to similar issues
> observed with other acceptors previously: GEODE-2898, GEODE-3023.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
