[
https://issues.apache.org/jira/browse/GEODE-5346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528140#comment-16528140
]
ASF subversion and git services commented on GEODE-5346:
--------------------------------------------------------
Commit 6ae3cada594be0a577b34c995bbc2f1f58a66c78 in geode's branch
refs/heads/feature/GEM-1772 from [~jens.deppe]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=6ae3cad ]
GEODE-5346: Fix race in LauncherLifecycleCommandsDUnitTest (#2080)
> Fix race in LauncherLifecycleCommandsDUnitTest
> ----------------------------------------------
>
> Key: GEODE-5346
> URL: https://issues.apache.org/jira/browse/GEODE-5346
> Project: Geode
> Issue Type: Bug
> Components: gfsh, management
> Reporter: Jens Deppe
> Assignee: Jens Deppe
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Errors such as the following sometimes occur:
> {noformat}
> org.apache.geode.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest
> > testVersionTitleForStartServerAndLocator FAILED
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at
> org.apache.geode.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest.readPid(LauncherLifecycleCommandsDUnitTest.java:195)
> at
> org.apache.geode.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest.waitForGemFireProcessToStop(LauncherLifecycleCommandsDUnitTest.java:260)
> at
> org.apache.geode.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest.stopServer(LauncherLifecycleCommandsDUnitTest.java:237)
> at
> org.apache.geode.management.internal.cli.commands.LauncherLifecycleCommandsDUnitTest.testVersionTitleForStartServerAndLocator(LauncherLifecycleCommandsDUnitTest.java:449){noformat}
>
> Fix a race where we wait for a component to stop by calling {{stop()}} and
> then waiting for the pid to disappear. The stop action happens in a different
> thread so the pid may disappear before the checking thread actually gets to
> check it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
