Patrick Rhomberg created GEODE-5506:
---------------------------------------
Summary: Various Concourse scripts are inconsistent with $DIR
variable, leaving it undefined in many cases
Key: GEODE-5506
URL: https://issues.apache.org/jira/browse/GEODE-5506
Project: Geode
Issue Type: Task
Reporter: Patrick Rhomberg
For instance, the {{concourse_job_performance.sh}} and many others contain a
boiler-plate:
{noformat}
SOURCE="${BASH_SOURCE[0]}"
while [ -h "$SOURCE" ]; do # resolve $SOURCE until the file is no longer a
symlink
SCRIPTDIR="$( cd -P "$( dirname "$SOURCE" )" && pwd )"
SOURCE="$(readlink "$SOURCE")"
[[ $SOURCE != /* ]] && SOURCE="$DIR/$SOURCE" # if $SOURCE was a relative
symlink, we need to resolve it relative to the path where the symlink file was
located
done
SCRIPTDIR="$( cd -P "$( dirname "$SOURCE" )" && pwd )"
{noformat}
Often, that boilerplate is prefaced with, as in
{{concourse_job_performance.sh}}, with
{noformat}
set -e
WORKDIR=${1}
{noformat}
The use here of {{WORKDIR}} may be the intended target of the {{DIR}} variable
below.
This problem exists in other scripts, using other variable names, but
frequently still leaving {{DIR}} undefined.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
