[
https://issues.apache.org/jira/browse/GEODE-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581895#comment-16581895
]
ASF subversion and git services commented on GEODE-5248:
--------------------------------------------------------
Commit 5e73f062a1fca05bb9002f7a7ef9ad8b9265e49f in geode's branch
refs/heads/develop from Juan Jose Ramos Cassella
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=5e73f06 ]
GEODE-5248: Fixes in GatewayReceiverMBeanBridge
The class `GatewayReceiverMBeanBridge` uses the `MBeanStatsMonitor` to
retrieve the amount of senders currently connected. This statistic
tends to be out of date and heavily depends on the `HostStatSampler`
class to run periodically and update the data. Whenever a receiver is
stopped its stats are also closed and, as such, the
`clientConnectionCount` is not updated anymore, resulting in a wrong
gateway-sender connected count reported.
- Fixed some minor warnings.
- Added tests to verify the accuracy of the current gateway-senders
connected.
- Renamed `WanCommandListDUnitTest` to `ListGatewaysCommandDUnitTest`.
- Modified the `GatewayReceiverMBeanBridge` to retrieve the current
client connection count from the underlying acceptor instead of
the `MBeanStatsMonitor` class.
> The gfsh list gateways command can show non-0 Sender Count when there are no
> senders connected
> ----------------------------------------------------------------------------------------------
>
> Key: GEODE-5248
> URL: https://issues.apache.org/jira/browse/GEODE-5248
> Project: Geode
> Issue Type: Bug
> Components: wan
> Reporter: Barry Oglesby
> Assignee: Juan José Ramos Cassella
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> With three members in each site, the gfsh list gateways command shows
> something like this for the receiving site members:
> {noformat}
> Member | Port | Sender Count | Senders Connected
> --------------------------------- | ---- | ------------ |
> -------------------------------------------------------------------------------------------------------
> 192.168.2.13(ny-1:90963)<v1>:1026 | 5317 | 8 |
> 192.168.2.13(ln-1:91017)<v1>:1029, 192.168.2.13(ln-2:91027)<v2>:1030,
> 192.168.2.13(ln-3:91037)<v3>:1031
> 192.168.2.13(ny-2:90979)<v2>:1027 | 5232 | 8 |
> 192.168.2.13(ln-1:91017)<v1>:1029, 192.168.2.13(ln-3:91037)<v3>:1031,
> 192.168.2.13(ln-2:91027)<v2>:1030
> 192.168.2.13(ny-3:90996)<v3>:1028 | 5403 | 8 |
> 192.168.2.13(ln-1:91017)<v1>:1029, 192.168.2.13(ln-2:91027)<v2>:1030,
> 192.168.2.13(ln-3:91037)<v3>:1031
> {noformat}
> If two of the receivers are stopped like this then the senders will connect
> to the remaining receiver:
> {noformat}
> stop gateway-receiver --member=ny-1
> Member | Result | Message
> --------------------------------- | ------ |
> ----------------------------------------------------------------------
> 192.168.2.13(ny-1:90963)<v1>:1026 | OK | GatewayReceiver is stopped on member
> 192.168.2.13(ny-1:90963)<v1>:1026
> stop gateway-receiver --member=ny-2
> Member | Result | Message
> --------------------------------- | ------ |
> ----------------------------------------------------------------------
> 192.168.2.13(ny-2:90979)<v2>:1027 | OK | GatewayReceiver is stopped on member
> 192.168.2.13(ny-2:90979)<v2>:1027
> {noformat}
> The list gateways command for the receiving site will show all the senders
> connected to the one remaining receiver like:
> {noformat}
> Member | Port | Sender Count | Senders Connected
> --------------------------------- | ---- | ------------ |
> -------------------------------------------------------------------------------------------------------
> 192.168.2.13(ny-1:90963)<v1>:1026 | 5317 | 8 |
> 192.168.2.13(ny-2:90979)<v2>:1027 | 5232 | 8 |
> 192.168.2.13(ny-3:90996)<v3>:1028 | 5403 | 18 |
> 192.168.2.13(ln-1:91017)<v1>:1029, 192.168.2.13(ln-2:91027)<v2>:1030,
> 192.168.2.13(ln-3:91037)<v3>:1031
> {noformat}
> But it doesn't 0 out the Sender Count for the two members whose receiver was
> stopped. It still shows 8 even though senders are no longer connected.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
