[
https://issues.apache.org/jira/browse/GEODE-5531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586198#comment-16586198
]
ASF subversion and git services commented on GEODE-5531:
--------------------------------------------------------
Commit 635567243a8ba667f04491aa5cfc80e4468822b2 in geode's branch
refs/heads/feature/Micrometer from Juan José Ramos
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=6355672 ]
GEODE-5531/GEODE-1507: Variable Substitution in GFSH (#2291)
* `Gfsh.executeCommand` now substitutes all variables (overriding
`AbstractShell.executeCommand`) before delegating
the execution to the parent class (as `Gfsh.executeScriptLine` does).
* Fixed Performance Tests
> gfsh echo variable does not work as documented
> ----------------------------------------------
>
> Key: GEODE-5531
> URL: https://issues.apache.org/jira/browse/GEODE-5531
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Derek Williams
> Assignee: Juan José Ramos Cassella
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Variables are [documented
> here|http://geode.apache.org/docs/guide/16/tools_modules/gfsh/useful_gfsh_shell_variables.html]
> to work with gfsh echo, but do not. This applies to both pre-defined shell
> variables and user-defined variables (set variable...).
> For example,
> {code}
> echo --string=$*
> {code}
> will show all shell variables and values, but
> {code}
> echo --string=${SYS_USER}
> {code}
> simply displays ${SYS_USER}
> Indeed,
> [EchoCommand.java|https://github.com/apache/geode/blob/78dcf4b8fa86543e882365e78f1c8e2a623bffde/geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/EchoCommand.java]
> has a special case for `$*`, but does not include the other documented cases.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
