[ 
https://issues.apache.org/jira/browse/GEODE-5589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586200#comment-16586200
 ] 

ASF subversion and git services commented on GEODE-5589:
--------------------------------------------------------

Commit 9000665bc2e9b657af5fa49331a31dd4848a04d1 in geode's branch 
refs/heads/feature/Micrometer from [~nabarunnag]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=9000665 ]

GEODE-5589: lastResultReceived set after msg sent (#2341)

        * To prevent situations where exceptions thrown in lastResult is not 
sent to the client.
        * This happens if we set the lastResultReceived and then an exception 
occurs.
        * exception is not sent back because the flag is set.
        * solution is now to set the flag only after the msg is sent from 
lastResult.

> lastResultReceived is set to true well before the last message is sent
> ----------------------------------------------------------------------
>
>                 Key: GEODE-5589
>                 URL: https://issues.apache.org/jira/browse/GEODE-5589
>             Project: Geode
>          Issue Type: Bug
>          Components: functions
>            Reporter: nabarun
>            Assignee: nabarun
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> *+Issue+*:
> - In the method lastResult we immediately set the lastResultReceived to be 
> true.
> - If an exception occurs after the flag is set and before the message is sent 
> (like security exception)
> - Then this exception will never be sent to the client because the 
> lastResultReceived is set and clients will be stuck waiting for the function 
> results.
> *+Solution+*:
> - set the flag after the message is sent.
> *+Affected code+* :
> - ServerToClientFunctionResultSender65.java
> - ServerToClientFunctionResultSender.java



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to