Patrick Rhomberg created GEODE-5606:
---------------------------------------

             Summary: CategoryWithParameterizedRunnerFactory can be removed
                 Key: GEODE-5606
                 URL: https://issues.apache.org/jira/browse/GEODE-5606
             Project: Geode
          Issue Type: Improvement
          Components: tests
            Reporter: Patrick Rhomberg


Previously, this test runner was required for compatibility with any test using 
{{@RunWith(Parameterized.class)}}.  See GEODE-4122 for details.

The issue presented in GEODE-4122 et al that was solved by the 
{{CategoryWithParameterizedRunnerFactory}} is a non-issue in current versions 
of Gradle's JUnit plugin.  This class and its annotated consumption can be 
safely removed.

Steps taken to verify the above:

* Check out {{0f8cd8e1ef12ab864f5b2ae7a0556156b249b432}} (fix for GEODE-4122)
* Remove runner from some test using it, e.g., 
{{GatewayReceiverXmlParsingValidationsJUnitTest}}
* Clean environment ({{./gradlew clean}} and delete {{out}} and {{build}} 
directories)
* Run target test, e.g., via {{./gradlew :geode-core:integrationTest --tests 
GatewayReceiverXmlParsingValidationsJUnitTest}}
* Inspect test report
* Note that no test was executed.
* Check out {{develop}}
* Clean environment again.
* Remove runner from the same test
* Execute test via same gradle command
* Inspect test report
* Note that the test was indeed run




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to