[ 
https://issues.apache.org/jira/browse/GEODE-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591773#comment-16591773
 ] 

ASF subversion and git services commented on GEODE-5630:
--------------------------------------------------------

Commit abb2702eb252efc2e27ba78d6dde8fc2bac13545 in geode's branch 
refs/heads/windows-heavy-lifter from [~apa...@the9muses.net]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=abb2702 ]

GEODE-5630: fix use of Awaitility in BucketCreationCrashCompletesRegressionTest


> Some tests using await should use until instead of untilAsserted
> ----------------------------------------------------------------
>
>                 Key: GEODE-5630
>                 URL: https://issues.apache.org/jira/browse/GEODE-5630
>             Project: Geode
>          Issue Type: Bug
>          Components: tests
>            Reporter: Kirk Lund
>            Assignee: Kirk Lund
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Awaitility was upgraded for GEODE-5593 and most or all of the 
> await()...until() calls were changed to await()...untilAsserted(). One or 
> more of these that are now incorrect.
> BucketCreationCrashCompletesRegressionTest line 173 is now:
> {noformat}
>       await().atMost(2, MINUTES).untilAsserted(() -> {
>         hasBucketOwners(partitionedRegion, bucketId);
>       });
> {noformat}
> But hasBucketOwners returns a boolean and does not perform any assertions.
> I'll fix this test and then review every other test that was changed to use 
> untilAsserted.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to