[
https://issues.apache.org/jira/browse/GEODE-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606635#comment-16606635
]
ASF subversion and git services commented on GEODE-5677:
--------------------------------------------------------
Commit f73b64294bf4ffb01d30a169220f89084bfc085b in geode-native's branch
refs/heads/develop from Jacob Barrett
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=f73b642 ]
GEODE-5677: Removes _GEODE_FRIEND_STD_SHARED_PTR. (#345)
* Make all shared_ptr bound classes have public constructors.
* Correct missing virtual destructors.
* Correct deleted functions.
* Other minor CLang 6.0 fixes.
> Remove _GEODE_FRIEND_STD_SHARED_PTR
> -----------------------------------
>
> Key: GEODE-5677
> URL: https://issues.apache.org/jira/browse/GEODE-5677
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Blake Bender
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> This caused us for a long time to delay upgrading to recent versions of
> XCode, and could easily be broken again by changes to what are supposed to be
> internal classes to the STL. This definition is kind of a kludge to allow us
> to protect constructors of certain classes while still making them creatable
> via std::make_shared. Rather than go to this length to protect developers
> from themselves, we'll make the constructors in question public and remove
> the macro altogether.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
