[
https://issues.apache.org/jira/browse/GEODE-5705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607522#comment-16607522
]
ASF subversion and git services commented on GEODE-5705:
--------------------------------------------------------
Commit c7878ffe26e9efe6be08e7a1ef88dde396e85c48 in geode's branch
refs/heads/feature/GEODE-5705 from [~ukohlmeyer]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=c7878ff ]
GEODE-5705: fixed logic to read Strings avoid double switch statements.
Cleaned up more locations where switch statements could have been used.
> InternalDataSerializer.basicReadObject convert IF to Switch
> -----------------------------------------------------------
>
> Key: GEODE-5705
> URL: https://issues.apache.org/jira/browse/GEODE-5705
> Project: Geode
> Issue Type: Improvement
> Components: serialization
> Reporter: Udo Kohlmeyer
> Assignee: Udo Kohlmeyer
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.8.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In the InternalDataSerializer.basicReadObject, there are if statements for
> EVERY DSCODE defined. This has two major problems,
> * The JIT compiler cannot easily improve this method, due to its size (1.3K)
> * There is a worst case performance, that every condition is evaluated to
> read a serialized object.
> Converting this IF structure to switch the 2nd point is improved. The first
> point is reduced to 754bytes, which is still not optimal to inline but at
> least smaller and can still be improved.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
