[
https://issues.apache.org/jira/browse/GEODE-3900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614440#comment-16614440
]
ASF subversion and git services commented on GEODE-3900:
--------------------------------------------------------
Commit 4290946d9dab98450964bbf498beea2bee650a3f in geode's branch
refs/heads/feature/GEODE-5729 from [~apa...@the9muses.net]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=4290946 ]
GEODE-4273: overhaul DiskRegionJUnitTest (#2449)
* Remove use of base class
* Extract testCompactorClose to DiskRegionCompactorCloseIntegrationTest
* Extract testDiskRegDWAttrbts to DiskRegionAttributesIntegrationTest
* GEODE-3900: Use TemporaryFolder for all disk dirs and files
* Ensure Cache and DS have proper tearDown
* Use Rules, Awaitility, and AssertJ
* Use CountDownLatch instead of verbose synchronization tricks
* Minimize usage of non-User APIs
* Fix usage of deprecated APIs
* Use proper variable names
* Use MAX_OPLOG_SIZE_IN_BYTES instead of literal value
* Protect AtomicReferences with Awaitility to prevent NPEs
> DiskRegionJUnitTest should use TemporaryFolder and needs simpler error
> handling
> -------------------------------------------------------------------------------
>
> Key: GEODE-3900
> URL: https://issues.apache.org/jira/browse/GEODE-3900
> Project: Geode
> Issue Type: Bug
> Components: tests
> Reporter: Kirk Lund
> Assignee: Kirk Lund
> Priority: Major
>
> DiskRegionJUnitTest has a TemporaryFolder but doesn't use it for all disk
> folders and files.
> DiskRegionJUnitTest also has broken error handling using static volatiles and
> if blocks with invocations of Assert.fail. This should be cleaned up (ie
> deleted).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
