[
https://issues.apache.org/jira/browse/GEODE-5259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624010#comment-16624010
]
ASF subversion and git services commented on GEODE-5259:
--------------------------------------------------------
Commit 576ff68eab8cdc6b626dd74a915a554a3c3173c1 in geode-native's branch
refs/heads/develop from [~bbender]
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=576ff68 ]
GEODE-5259: Fix clang (xcode 10) build breaks (#360)
- remove unused parameters from
SerializableHelper<DataSerializableInternal>::metadataEqualTo()
- remove problematic clang-format properties
- remove gratuitous type cast
Co-authored-by: Mike Martell <[email protected]>
Co-authored-by: Ivan Godwin <[email protected]>
> DataSerializable objects should not have fixed ClassId properties
> -----------------------------------------------------------------
>
> Key: GEODE-5259
> URL: https://issues.apache.org/jira/browse/GEODE-5259
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Jacob S. Barrett
> Priority: Major
> Labels: pull-request-available
> Time Spent: 11h 20m
> Remaining Estimate: 0h
>
> Like the Java version of these classes the ClassId should be registered with
> the Class and on a per Cache/DS basis.
>
> Remove ClassId from DataSerializable and add it to the
> TypeRegistry::RegisteryType call.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
