[ 
https://issues.apache.org/jira/browse/GEODE-5741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627816#comment-16627816
 ] 

ASF subversion and git services commented on GEODE-5741:
--------------------------------------------------------

Commit fe533c60edb4c3cea56540f5e873f47b04cb74ff in geode's branch 
refs/heads/develop from [~khowe]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fe533c6 ]

GEODE-5741: Modified tests to be independent of environment (#2496)

* GEODE-5741: Modified tests to be independent of environment

Tests using relative paths had depended on running as a user other than root.
The tests expceted that file or directpory creation would fail because the user
would not have permission to write to filesystem root.

A further problem was the several tests had hardcoded '/' in pathnames,
which is incompatible with running on Windows.

* make tests use relative paths
* remove system dependent path separators
* move tests that expect directory creation to fail to StartMemberUtilsTest.
* On entry to testGeodeOnClasspathIsFirst there may (depending test platform) 
be a version of geode-core-*.jar on the system classpath, but at an unknown 
position
in tthe list. Now, a dummy geode-core-*.jar path is inserted in the system
classpath at a known, but not the first, position.


> StartLocatorCommandDUnitTest relative directory tests are not build 
> environment independant
> -------------------------------------------------------------------------------------------
>
>                 Key: GEODE-5741
>                 URL: https://issues.apache.org/jira/browse/GEODE-5741
>             Project: Geode
>          Issue Type: Bug
>          Components: gfsh
>            Reporter: Kenneth Howe
>            Assignee: Kenneth Howe
>            Priority: Major
>              Labels: pull-request-available, swat
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> The tests that attempt to start locators from paths at the file system root, 
> '/', expect to fail directory creation due to no write permission. However, 
> if the tests are run as root, then directory creation succeeds.
> These tests furthermore use paths with hardcoded '/' in the paths so they 
> will not run properly on Windows.
> The tests shold be made system and build/test environment independent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to