[ 
https://issues.apache.org/jira/browse/GEODE-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Martell updated GEODE-5837:
-----------------------------------
    Description: 
Significant pieces of code in TcrMessage are not being tested. New tests should 
be written to test the following:
 * inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg, 
DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType, 
const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk)
 * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg, 
DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen, 1336 
: uint8_t isLastChunk)
 * void TcrMessage::processChunk(const uint8_t* bytes, int32_t len, 724 : 
uint16_t endpointmemId, 725 : const uint8_t isLastChunkAndisSecurityHeader)

lcov results are shown in the attachments

  was:
Significant pieces of code in TcrMessage are not being tested. New tests should 
be written to test the following:
 * inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg, 
DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType, 
const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk)
 * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg, 
DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen, 1336 
: uint8_t isLastChunk)
 * 
 void TcrMessage::processChunk(const uint8_t* bytes, int32_t len,     724       
      :                               uint16_t endpointmemId,     725           
  :                               const uint8_t isLastChunkAndisSecurityHeader)

lcov results are shown in the attachments


> Create New Tests to Fix Coverage Holes in TcrMessage
> ----------------------------------------------------
>
>                 Key: GEODE-5837
>                 URL: https://issues.apache.org/jira/browse/GEODE-5837
>             Project: Geode
>          Issue Type: Task
>          Components: native client
>            Reporter: Michael Martell
>            Priority: Major
>         Attachments: TcrMessage.cpp.gcov.html, TcrMessage.hpp.gcov.html
>
>
> Significant pieces of code in TcrMessage are not being tested. New tests 
> should be written to test the following:
>  * inline static ChunkObjectType readChunkPartHeader( 1259 : TcrMessage& msg, 
> DataInput& input, DSCode expectedFirstType, 1260 : int32_t expectedPartType, 
> const char* methodName, uint32_t& partLen, 1261 : uint8_t isLastChunk)
>  * inline static ChunkObjectType readChunkPartHeader(TcrMessage& msg, 
> DataInput& input, 1334 : const char* methodName, 1335 : uint32_t& partLen, 
> 1336 : uint8_t isLastChunk)
>  * void TcrMessage::processChunk(const uint8_t* bytes, int32_t len, 724 : 
> uint16_t endpointmemId, 725 : const uint8_t isLastChunkAndisSecurityHeader)
> lcov results are shown in the attachments



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to